-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes #178
Misc fixes #178
Conversation
Apparently nobody was using this feature and did not notice that lots of code in _EXTRA macro does not work with __has_include().
Actually do not merge just yet. There will be more like |
bc281ef
to
1ca9e9c
Compare
FYI you can mark you PR as a draft until you're happy with it. |
…elHandle defined here.
1ca9e9c
to
f2cc463
Compare
Huh how? |
On the right where you can see assigned, reviewers etc, there's a text-link based button to convert to draft, somewhere |
Nice! Thanks 🙏🏻 |
Thanks! I'll wait for your green light then. I think we're probably going to keep breaking EASTL unless somebody adds it to the CI ;) |
All good, took me few iterations where to put |
Alright, thanks for this! Nice to know it builds on UWP as well now :) |
Sorry for moving slow, here are my promised fixes.
RMLUI_*_USER_EXTRA
. Nobody was using it and did not notice that random code in these macros break build because pasting that code within__has_include()
is not well-formed.DataModelHandle
(wanted byeastl::function
).