Bump rubocop to 1.46 #1051
Merged
Bump rubocop to 1.46 #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy for the update, but curious. Since it's just a development dependency, how it is preventing you from upgrading? |
|
In our Gemfile.lock, rubocop gets pinned to the version specified by wicked_pdf and the |
|
Thanks. I'll have to check that out. |
|
Thanks! Forgot, should we bump the version? |
|
You don't have to, but if you'd like to help me get a gem release out, I would appreciate if you could add merged, but unreleased PRs to the CHANGELOG, and bump the version in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Bumping rubocop to the most recent version as we are using wicked_pdf in production but it's preventing us from running a more recent version of rubocop that supports Ruby 3.2