Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow/Fix precompiled assets with Propshaft pipeline #1120

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

serggl
Copy link
Contributor

@serggl serggl commented Jun 11, 2024

Purpose

rails/propshaft support was added with #1010
However it appears to only work with dynamic assets and fails with precompiled ones:

#<UncaughtThrowError: uncaught throw #<ActionView::Template::Error: undefined local variable or method `content' for an instance of WickedPdf::WickedPdfHelper::Assets::PropshaftAsset>>

Solution

Improve the original solution and use Propshaft's built-in resolver to handle gracefully both asset types

@serggl
Copy link
Contributor Author

serggl commented Jun 11, 2024

@unixmonkey please review 🙏🏽

@rafaeldev
Copy link

Is there any update about it?

@mfittko
Copy link

mfittko commented Mar 10, 2025

@unixmonkey We also need this, could we please get this out?

@unixmonkey unixmonkey merged commit 9b5931f into mileszs:master Mar 10, 2025
12 checks passed
@unixmonkey
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants