render_to_string fix #962
render_to_string fix #962
Conversation
|
Why is this desirable for you? This means if you call render with a block or arguments, they will now be ignored. Is this from a change in Rails internals or something? |
| @@ -22,7 +22,7 @@ def render(*args) | |||
| def render_to_string(*args) | |||
| options = args.first | |||
| if options.is_a?(Hash) && options.key?(:pdf) | |||
| render_to_string_with_wicked_pdf(options, *args, &block) | |||
There was a problem hiding this comment.
block indeed does not exist here... but should we keep *args ?
There was a problem hiding this comment.
method below does not take a 2nd arg... so this looks correct
There was a problem hiding this comment.
problem introduced in #925
It appears this is missing some tests.
this should be part of next release
|
PDF generation in my project stopped work because of this issue. It happened after an update on 2.6.0 from 2.1.0.
Will be good to see these changes in the next release. |
|
manual merge into master here all tests passed - https://github.com/mathieujobin/wicked_pdf/actions/runs/2268571025 |
|
This has been released in version 2.6.2. Please let me know if you have any issues. |
pass options only to the render_to_string_with_wicked_pdf