Finish GitHub actions transition #987
Conversation
wicked_pdf.gemspec
Outdated
| @@ -21,7 +21,7 @@ DESC | |||
| 'changelog_uri' => 'https://github.com/mileszs/wicked_pdf/blob/master/CHANGELOG.md' | |||
| } | |||
|
|
|||
| spec.required_ruby_version = Gem::Requirement.new('>= 2.2') | |||
| spec.required_ruby_version = Gem::Requirement.new('>= 2.6') | |||
There was a problem hiding this comment.
Is there a reason to raise this minimum Ruby version, and by so much? I'd like people on older rubies to still be able to use this gem.
There was a problem hiding this comment.
We can maintain this old ruby version, if you prefer, no problem 🤝 But CI tests may not guarantee it works well on such older versions of the gem + rails version used
There was a problem hiding this comment.
I made rollback on this change, returning to ruby 2.2 👍
There was a problem hiding this comment.
My two cents here, I usually keep CI to run for old versions as long as tests pass.
Once we hit a failure, then we take the decision if it's worth fixing or moving on, deprecating the failing version.
| gem 'rdoc' | ||
| gem 'sqlite3', '~> 1.4' | ||
|
|
||
| gemspec path: '../' |
There was a problem hiding this comment.
Why not keeping Rails Edge? 7.0 is just around the corner. I have an app running it already.
Maybe just allow-failures on edge
Hello, @unixmonkey ! 👋
This PR finishes the Github Actions transition started at #986 🎉
New cops are present in recent rubocops versions (that is needed for Ruby 3 support), but initially them are disabled. Later, it will be possible to "turn on" each one of them and change the source code to be compliant with each rule. But is better to make it gradually 🤝
Let me know your thoughts about it 🕺
Thanks! 🤓