fix: webpacker_source_url
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the change in mileszs#973, I've experienced an issue where images are not being embedding in the pdf generated (in non development environments) when using the following: ``` image_tag wicked_pdf_asset_pack_path("static/example.png") ``` For context: The pdfs are being generated via a background job on a separate sever to the webapp, so using the `asset_host` option is not ideal, as the pdf would then need to fetch the assets from another server when they're already available locally. I have tried For context setting `Rails.application.config.asset_host` via `production.rb` to no avail. This commit reinstates the original functionality prior to mileszs#973, whist still retaining the new functionality add via mileszs#973.
unixmonkey
approved these changes
Nov 19, 2021
|
@unixmonkey Thanks for actioning so quickly. I think there would be merit in releasing a new version (if possible)? If only to close #891, as I think there are a few people tracking I was asked on #891 (comment) if I could release a new version a while back 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the change in #973, I've experienced an issue where images are not
being embedding in the pdf generated (in non development environments)
when using the following:
For context: The pdfs are being generated via a background job on a
separate sever to the webapp, so using the
asset_hostoption is notideal, as the pdf would then need to fetch the assets from another server
when they're already available locally. Although not ideal, I have tried setting
Rails.application.config.asset_hostviaproduction.rbto no avail.This commit reinstates the original functionality prior to #973, whist
still retaining the new functionality add via #973.