Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpacker_source_url #993

Merged
merged 1 commit into from
Nov 19, 2021
Merged

fix: webpacker_source_url #993

merged 1 commit into from
Nov 19, 2021

Conversation

davegudge
Copy link
Contributor

@davegudge davegudge commented Nov 18, 2021

Since the change in #973, I've experienced an issue where images are not
being embedding in the pdf generated (in non development environments)
when using the following:

image_tag wicked_pdf_asset_pack_path("static/example.png")

For context: The pdfs are being generated via a background job on a
separate sever to the webapp, so using the asset_host option is not
ideal, as the pdf would then need to fetch the assets from another server
when they're already available locally. Although not ideal, I have tried setting
Rails.application.config.asset_host via production.rb to no avail.

This commit reinstates the original functionality prior to #973, whist
still retaining the new functionality add via #973.

Since the change in mileszs#973, I've experienced an issue where images are not
being embedding in the pdf generated (in non development environments)
when using the following:

```
image_tag wicked_pdf_asset_pack_path("static/example.png")
```

For context: The pdfs are being generated via a background job on a
separate sever to the webapp, so using the `asset_host` option is not
ideal, as the pdf would then need to fetch the assets from another server
when they're already available locally. I have tried For context setting
`Rails.application.config.asset_host` via `production.rb` to no avail.

This commit reinstates the original functionality prior to mileszs#973, whist
still retaining the new functionality add via mileszs#973.
@unixmonkey unixmonkey merged commit b427b37 into mileszs:master Nov 19, 2021
@davegudge
Copy link
Contributor Author

@unixmonkey Thanks for actioning so quickly. I think there would be merit in releasing a new version (if possible)? If only to close #891, as I think there are a few people tracking master.

I was asked on #891 (comment) if I could release a new version a while back 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants