Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the change in #973, I've experienced an issue where images are not
being embedding in the pdf generated (in non development environments)
when using the following:
For context: The pdfs are being generated via a background job on a
separate sever to the webapp, so using the
asset_host
option is notideal, as the pdf would then need to fetch the assets from another server
when they're already available locally. Although not ideal, I have tried setting
Rails.application.config.asset_host
viaproduction.rb
to no avail.This commit reinstates the original functionality prior to #973, whist
still retaining the new functionality add via #973.