Exclude jar signing signature của thư viện bcrypt

[minhh2792]

Thư viện này file jar được sign bằng private key của tác giả, phải exclude mấy file signature gì đó trong meta-inf thì mới load được plugin MineVNLib

https://discord.com/channels/1068181110036635678/1068184175984779306/1328332017523359746

Summary by CodeRabbit

• Chores
  • Updated build configuration to exclude specific signature-related files during JAR packaging.

[coderabbitai]

Walkthrough

The pull request modifies the build.gradle.kts file for the minevnlib-plugin, specifically updating the ShadowJar task configuration. The change introduces additional exclusion rules for META-INF signature-related files (RSA, DSA, and SF files), which will prevent these specific digital signature files from being included in the final shadowed JAR artifact.

Changes

File	Change Summary
minevnlib-plugin/build.gradle.kts	Added exclusion rules for META-INF signature files in ShadowJar task

Poem

🐰 A gradle tale of shadows light,
Signature files now take flight!
RSA, DSA, SF begone,
Our JAR now clean, our build moves on!
Hop hop hooray for cleaner code! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

minevnlib-plugin/build.gradle.kts (1)

66-66: Consider adding a comment explaining the signature exclusion.

Adding a brief comment would help future maintainers understand why these signature files need to be excluded, especially in relation to the bcrypt library.

+        // Exclude original jar signatures as they become invalid after relocation
         exclude("META-INF/*.RSA", "META-INF/*.DSA", "META-INF/*.SF")

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 695174f and 23cfca9.

📒 Files selected for processing (1)

• minevnlib-plugin/build.gradle.kts (1 hunks)

🔇 Additional comments (1)

minevnlib-plugin/build.gradle.kts (1)

66-66: LGTM! The signature exclusion pattern is correct.

The exclusion of signature files (RSA, DSA, SF) from META-INF is necessary and correctly implemented. This is a common practice when using the Shadow plugin, as the original signatures become invalid after package relocation anyway.