-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix go module imports properly to honor semantic versioning #1111
Conversation
c260420
to
b5a10f5
Compare
b5a10f5
to
f6254f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey, sorry for hijacking a closed PR, but I cannot any other guide as to why a local project which was building lately is now broken because of this v6 change...is it intended to be a breaking change? I get lots of |
@admoriarty I also ran into this and need a fix. (Is there any way to get |
You need to use |
I've tried...
Actually, to be accurate, I may be able to get beyond it in one case and then failing with a "gcc cannot be found" error which seems very commonplace but the common fixes of setting env vars doesn't help :D |
You are not doing it correctly @admoriarty first your code should depend on minio-go and then you have to go mod tidy to get the latest released version of minio-go You have to follow the go mod instructions and it will work fine. |
Take a look at how to use it https://github.com/minio/mc/pull/2782/files |
No description provided.