Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reverse version for listObjectVersions #2072

Merged

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Feb 27, 2025

feat: add reverse version for listObjectVersions
We need a sorted a versions by time for some case.

@jiuker jiuker requested review from harshavardhana, klauspost and ramondeklein and removed request for harshavardhana February 27, 2025 09:02
feat: add reverse version for listObjectVersions
@jiuker jiuker force-pushed the add-reverseversion-for-listObjectVersion branch from 9280f08 to f471f69 Compare February 28, 2025 01:18
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change.

jiuker added 3 commits March 3, 2025 11:28
fix timestamps equal
add 	versionNumbers
Reverse
@jiuker jiuker requested a review from klauspost March 3, 2025 04:12
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jiuker
Copy link
Contributor Author

jiuker commented Mar 5, 2025

@harshavardhana PTAL

jiuker and others added 2 commits March 5, 2025 13:11
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
@jiuker jiuker requested a review from harshavardhana March 5, 2025 05:11
WithVersions
@harshavardhana harshavardhana merged commit c34f06b into minio:master Mar 5, 2025
5 checks passed
@jiuker jiuker deleted the add-reverseversion-for-listObjectVersion branch March 6, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants