Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RemoveObjectsWithContext call #939

Merged
merged 3 commits into from
Mar 5, 2018

Conversation

awwalker
Copy link
Contributor

@awwalker awwalker commented Mar 3, 2018

Fix for: #906

@nitisht
Copy link
Contributor

nitisht commented Mar 3, 2018

Thanks for the PR @awwalker will review in a bit.

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition @awwalker . Do you mind adding doc reference as well. Here is where you can add the info https://github.com/minio/minio-go/blob/master/docs/API.md#RemoveObjects

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 28c11a5 into minio:master Mar 5, 2018
@awwalker awwalker deleted the feature-remove-objects-ctx branch March 5, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants