-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change import httplex to httpguts. #981
Conversation
That seems to break compilation with Go 1.10... Is this intentional? |
Yes why would it break? . I am using go 1.10.2. you need to fetch the new dependencies Go upstream broke the dependency by moving the package so we have to do it. |
I'm getting |
|
That's not that easy... We need to build against reusable package Never mind though, for now I've uploaded minio-go 6.0.1. Thanks. |
Well I think that style of packaging never really works in Go world, we have to update anyways since our users who use |
Fair enough. However IMHO golang vendoring mess is an abomination of 20+ years of best practice in software engineering. :) For example, no tests are run for any of (vendored) dependency libraries on build. In Debian we are trying to do it right by building reproducibly in offline build environment, running tests for all libraries on all supported architectures, etc. Use "stable", semantically versioned libraries whenever possible (versus random commits, as often vendored by many Goland developers), etc. |
Perhaps, but from our end we can't do much. Perhaps Debian can work with Go developers to fix this problem. Perhaps the new vgo initiative is a good progress in that direction? |
Of course, of course. :) |
This fixes go get.
Breakage caused by: golang/net@cbb82b5