Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Set file to jobsqueue bucket #96

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Save Set file to jobsqueue bucket #96

merged 1 commit into from
Mar 17, 2025

Conversation

gregtyler
Copy link
Contributor

@gregtyler gregtyler commented Mar 14, 2025

Purpose

For easier debugging of issues

Fixes SSM-103 #minor

Approach

Saves the Set file as soon as possible (after we know it's valid string, before any validation/processing). It will automatically be deleted after 14 days.

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • I have updated documentation where relevant
  • I have added tests to prove my work

Sorry, something went wrong.

For easier debugging of issues

Fixes SSM-103 #minor
@gregtyler gregtyler force-pushed the SSM-103-save-set-file branch from a88a4cb to 74b4ad7 Compare March 17, 2025 09:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 37.08%. Comparing base (8d35480) to head (294258e).

Files with missing lines Patch % Lines
service-app/internal/aws/client.go 66.66% 7 Missing and 2 partials ⚠️
service-app/internal/api/handler.go 55.55% 3 Missing and 1 partial ⚠️
service-app/internal/aws/client_mock.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   36.64%   37.08%   +0.44%     
==========================================
  Files          55       55              
  Lines        2055     2095      +40     
==========================================
+ Hits          753      777      +24     
- Misses       1218     1231      +13     
- Partials       84       87       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregtyler gregtyler marked this pull request as ready for review March 17, 2025 09:56
@gregtyler gregtyler requested a review from a team as a code owner March 17, 2025 09:56
@gregtyler gregtyler force-pushed the SSM-103-save-set-file branch from 294258e to 74b4ad7 Compare March 17, 2025 10:43
@gregtyler gregtyler merged commit c41db5f into main Mar 17, 2025
29 checks passed
@gregtyler gregtyler deleted the SSM-103-save-set-file branch March 17, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants