Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEGA-2862 user can review restrictions and conditions #622

Merged
merged 7 commits into from
Mar 12, 2025

Conversation

MishNajam
Copy link
Contributor

@MishNajam MishNajam commented Mar 11, 2025

This PR fixes VEGA-2862 #minor :

  • adds the manage restrictions details form
  • adds a link to the form in the restrictions sections of the lpa-details page
  • moves the manage restrictions details into it's own template
  • returns an error when submitting the form with no option selected
  • returns a not implemented yet error when selecting severance is required when the restrictions task is open
  • clears the restrictions task when severance is not required
  • adds unit and cypress tests

Checklist

  • I have updated the end-to-end tests to work with my changes
  • I have added styling for Dark Mode
  • I have checked that my UI changes meet accessibility standards

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
manasvinibs Manasvini B Suryanarayana

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
@MishNajam MishNajam requested review from a team as code owners March 11, 2025 15:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 87.32394% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (be2e19f) to head (39c8c9f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/server/manage_restrictions.go 87.14% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   72.65%   72.63%   -0.03%     
==========================================
  Files         127      129       +2     
  Lines        5724     5840     +116     
==========================================
+ Hits         4159     4242      +83     
- Misses       1208     1229      +21     
- Partials      357      369      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MishNajam MishNajam merged commit 23750b7 into main Mar 12, 2025
19 checks passed
@MishNajam MishNajam deleted the VEGA-2862-recording-severance-not-required branch March 12, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants