Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(frontend): Notes Manager #11394

Closed
wants to merge 250 commits into from
Closed

perf(frontend): Notes Manager #11394

wants to merge 250 commits into from

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 26, 2023 •
edited
Loading

Resolve #7910

#11241 の続き

#11439 をマージしたためそちらを先にマージする必要あり

What

ノートマネージャでノートを一元管理する

Why

  • 常に新しい情報を表示する
  • 同一のノートが表示されがちなデッキでのパフォーマンス向上?

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@tamaina tamaina marked this pull request as ready for review August 12, 2023 15:06
@tamaina
Copy link
Contributor Author

tamaina commented Aug 12, 2023

うーん、notesSourceのrefをonStreamNoteUpdatedでアップデートしてもnotesComputedのcomputedがアップデートされない場合がある

何やっても解決しないのでcomputedをgetごとに生成することにした

@tamaina tamaina closed this Oct 22, 2023
@tamaina
Copy link
Contributor Author

tamaina commented Oct 22, 2023

コンフリクト解消を諦めたためclose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EbiseLutica EbiseLutica Awaiting requested review from EbiseLutica

@syuilo syuilo Awaiting requested review from syuilo

Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

クライアント内でノートのデータを一元的に管理する
2 participants
@tamaina @saschanaz