Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(backend): Improve behavior of correctFilename #11484

Merged
merged 6 commits into from
Aug 8, 2023
Merged

enhance(backend): Improve behavior of correctFilename #11484

merged 6 commits into from
Aug 8, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Aug 7, 2023 •
edited
Loading

Fix #11482

What

ファイルアップロード時等にファイル名の拡張子を修正する関数（correctFilename）の挙動を改善

correctFilenameのテストを書いた

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Aug 7, 2023
@github-actions github-actions bot requested a review from acid-chicken August 7, 2023 14:04
@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #11484 (2613dc9) into develop (db5046e) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11484      +/-   ##
===========================================
- Coverage    78.64%   78.61%   -0.03%     
===========================================
  Files          921      176     -745     
  Lines        97493    22827   -74666     
  Branches      7696      500    -7196     
===========================================
- Hits         76670    17946   -58724     
+ Misses       20823     4881   -15942

see 747 files with indirect coverage changes

@anatawa12 anatawa12 mentioned this pull request Aug 7, 2023
Closed
@tamaina tamaina requested a review from syuilo August 7, 2023 14:11
@tamaina
Copy link
Contributor Author

tamaina commented Aug 7, 2023

そもそも未知のファイル形式かつ拡張子がある場合は何もしないようにした

@syuilo syuilo merged commit f6a3f6f into misskey-dev:develop Aug 8, 2023
@syuilo
Copy link
Member

syuilo commented Aug 8, 2023

👍👍

anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Aug 16, 2023
@tamaina @syuilo @anatawa12
enhance(backend): Improve behavior of correctFilename (misskey-dev#11484
fb96dad 
)

* enhance(backend): Improve behavior of correctFilename

* ✌️

* 未知のファイル形式かつ拡張子がある場合は何もしない

* ✌️

* .ext

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acid-chicken acid-chicken Awaiting requested review from acid-chicken

@syuilo syuilo Awaiting requested review from syuilo

Assignees
No one assigned
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ドライブに上げたファイルの拡張子が変わる
2 participants
@tamaina @syuilo