Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine announcement #11497

Merged
merged 27 commits into from
Aug 13, 2023
Merged

feat: refine announcement #11497

merged 27 commits into from
Aug 13, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Aug 9, 2023

What

#11328

Why

Resolve #11328

Additional info (optional)

  • 既読お知らせのクライアント側キャッシュ
  • deactivateされたお知らせタブ
  • テスト
  • メール通知?

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #11497 (c8300bf) into develop (dc8a130) will increase coverage by 0.04%.
Report is 13 commits behind head on develop.
The diff coverage is 81.68%.

@@             Coverage Diff             @@
##           develop   #11497      +/-   ##
===========================================
+ Coverage    78.63%   78.68%   +0.04%     
===========================================
  Files          920      922       +2     
  Lines        97492    97688     +196     
  Branches      7704     7725      +21     
===========================================
+ Hits         76659    76861     +202     
+ Misses       20833    20827       -6     
Files Changed Coverage Δ
packages/backend/src/server/api/stream/types.ts 0.00% <0.00%> (ø)
packages/frontend/src/account.ts 13.96% <0.00%> (+0.04%) ⬆️
packages/frontend/src/components/MkNoteHeader.vue 100.00% <ø> (ø)
packages/frontend/src/components/MkNoteSimple.vue 100.00% <ø> (ø)
...c/server/api/endpoints/admin/announcements/list.ts 72.72% <8.33%> (-7.09%) ⬇️
.../backend/src/server/api/endpoints/announcements.ts 83.58% <41.66%> (+2.45%) ⬆️
...server/api/endpoints/admin/announcements/create.ts 83.33% <50.00%> (-3.88%) ⬇️
...server/api/endpoints/admin/announcements/update.ts 75.36% <54.54%> (-4.30%) ⬇️
...nd/src/server/api/endpoints/i/read-announcement.ts 94.87% <75.00%> (+30.91%) ⬆️
packages/backend/src/core/AnnouncementService.ts 84.44% <84.44%> (ø)
... and 6 more

... and 2 files with indirect coverage changes

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 9, 2023
@syuilo
Copy link
Member Author

syuilo commented Aug 11, 2023

image

@syuilo
Copy link
Member Author

syuilo commented Aug 11, 2023

70%くらい終わった

@syuilo syuilo marked this pull request as ready for review August 13, 2023 03:16
@github-actions github-actions bot requested a review from tamaina August 13, 2023 03:16
@syuilo
Copy link
Member Author

syuilo commented Aug 13, 2023

テスト書いた

@syuilo
Copy link
Member Author

syuilo commented Aug 13, 2023

マージするか

@syuilo syuilo merged commit 9487856 into develop Aug 13, 2023
@syuilo syuilo deleted the refine-announcement branch August 13, 2023 11:12
anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Aug 16, 2023
* wip

* Update read-announcement.ts

* wip

* wip

* wip

* Update index.d.ts

* wip

* Create 1691649257651-refine-announcement.js

* wip

* wip

* wip

* wip

* wip

* wip

* Update announcements.vue

* wip

* wip

* Update announcements.vue

* wip

* Update announcements.vue

* wip

* Update misskey-js.api.md

* Update users.ts

* Create MkAnnouncementDialog.stories.impl.ts

* wip

* wip

* Create AnnouncementService.ts
u1-liquid added a commit to u1-liquid/misskey that referenced this pull request Aug 17, 2023
nafu-at added a commit to TeamNijimiss/nijimiss_legacy that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

お知らせ機能の強化
1 participant