fix(backend): correctFilename changes dll to exe #11710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #11710 +/- ##
===========================================
- Coverage 78.67% 78.48% -0.19%
===========================================
Files 922 174 -748
Lines 97661 22710 -74951
Branches 7705 500 -7205
===========================================
- Hits 76830 17825 -59005
+ Misses 20831 4885 -15946 |
|
dll配布する場面ってどんな場面やねんと思ったけどとりあえずマージ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
.dllが.exeになるので.dllのままにするWhy
実行ファイルじゃないのが実行ファイル扱いを受けるので
Additional info (optional)
changelogは
ファイルアップロード時等にファイル名の拡張子を修正する関数(correctFilename)の挙動を改善に含められると思ったため更新してませんChecklist