enhance(frontend): CWの注釈テキストが入力されていない場合はPostボタンを非アクティブに #15639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15639 +/- ##
============================================
- Coverage 41.89% 15.34% -26.55%
============================================
Files 1625 787 -838
Lines 165998 72307 -93691
Branches 4107 1279 -2828
============================================
- Hits 69545 11099 -58446
+ Misses 95975 60783 -35192
+ Partials 478 425 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issueの本題からは逸れるものですが、(個人的には)逆にこの行だけを条件式から外したままにするほうが違和感を感じるので、一旦含めた形にしました。 |
|
この変更で(おそらく) |
r-ca
changed the title
tai-cha
approved these changes
Mar 10, 2025
kakkokari-gtyih
approved these changes
Mar 10, 2025
|
Thank you 🙏 |
DA-TENSHI
pushed a commit
to SHINANOSKEY-Projekt/SHINANOSKEY
that referenced
this pull request
Mar 10, 2025
…15639) * add condition to disable post button when CW text is empty * standardize condition by using 1<= inserted of 0< * unify CW text length condition to improve readability * add missing CW state check * fix state check, add empty/null check, improve max length validation * simplify CW validation by removing minimum length check * Update CHANGELOG * remove CW text validation in post() --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Ruruke
pushed a commit
to Ruruke/rukey
that referenced
this pull request
Mar 11, 2025
…15639) * add condition to disable post button when CW text is empty * standardize condition by using 1<= inserted of 0< * unify CW text length condition to improve readability * add missing CW state check * fix state check, add empty/null check, improve max length validation * simplify CW validation by removing minimum length check * Update CHANGELOG * remove CW text validation in post() --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
harumaki2000
pushed a commit
to harumaki2000/misskey-layp
that referenced
this pull request
Mar 11, 2025
…15639) * add condition to disable post button when CW text is empty * standardize condition by using 1<= inserted of 0< * unify CW text length condition to improve readability * add missing CW state check * fix state check, add empty/null check, improve max length validation * simplify CW validation by removing minimum length check * Update CHANGELOG * remove CW text validation in post() --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Resolve #14151
Additional info (optional)
Checklist