Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): テーマ設定で簡易プレビューを表示するように #15643

Conversation

kakkokari-gtyih
Copy link
Contributor

What

image

Why

UI改善
https://misskey.io/notes/a5629k4noswh0d0b

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 208 lines in your changes missing coverage. Please review.

Project coverage is 15.35%. Comparing base (9dce512) to head (adc0ce8).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/settings/theme.vue 0.00% 136 Missing ⚠️
...ackages/frontend/src/components/MkThemePreview.vue 0.00% 68 Missing and 1 partial ⚠️
...ntend/src/utility/autogen/settings-search-index.ts 0.00% 2 Missing ⚠️
packages/frontend/src/theme.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15643       +/-   ##
============================================
- Coverage    41.92%   15.35%   -26.57%     
============================================
  Files         1624      787      -837     
  Lines       165871    72311    -93560     
  Branches      4106     1279     -2827     
============================================
- Hits         69540    11103    -58437     
+ Misses       95854    60783    -35071     
+ Partials       477      425       -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mi-gh-maintainer mi-gh-maintainer bot merged commit f797765 into misskey-dev:develop Mar 10, 2025
22 of 24 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the enh-theme-settings-preview branch March 10, 2025 11:01
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Mar 10, 2025
* enhance(frontend): テーマ設定で簡易プレビューを表示するように

* Update Changelog

* fix lint

* 🎨

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Mar 11, 2025
* enhance(frontend): テーマ設定で簡易プレビューを表示するように

* Update Changelog

* fix lint

* 🎨

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants