Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localstack:stable is not publishing SNS messages due to subscription confirmation HTTP requests not sending a response #211

Closed
anaerobic opened this issue Oct 4, 2024 · 1 comment · Fixed by #212
Closed

localstack:stable is not publishing SNS messages due to subscription confirmation HTTP requests not sending a response #211

anaerobic opened this issue Oct 4, 2024 · 1 comment · Fixed by #212

Comments

@anaerobic
Copy link
Contributor

anaerobic commented Oct 4, 2024 •
edited
Loading

when localstack sends the subscription confirmation request we are fetching the SubscribeURL to enable the subscription at

serverless-offline-sns/src/sns-adapter.ts

Line 152 in b2987bd

return fetch(req.body.SubscribeURL, {
but we are not subsequently completing that subscription confirmation request, which looks to be exhausting the localstack HTTP connection pool with a sufficiently large number of SNS subscriptions.
@anaerobic anaerobic changed the title localstack:stable is not publishing SNS messages due to subscription confirmation HTTP connections not completing localstack:stable is not publishing SNS messages due to subscription confirmation HTTP requests not sending a response Oct 4, 2024
@anaerobic anaerobic mentioned this issue Oct 4, 2024
Merged
dsarlo pushed a commit that referenced this issue Oct 5, 2024
@anaerobic
#211 completing subscription confirmation requests (#212)
a3c3502 
* completing subscription confirmation requests

* fixing own contributor href

---------

Co-authored-by: Michael W. Martin <mmartin2@lifetimefitness.com>
@dsarlo
Copy link
Collaborator

dsarlo commented Oct 5, 2024

@anaerobic cut release 0.78.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#211 completing subscription confirmation requests anaerobic/serverless-offline-sns
2 participants
@anaerobic @dsarlo