Bump Mermaid version to 10.0.0 #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
requested changes
Feb 22, 2023
|
I've been seeing this issue in the logs, let's see if the fix helps |
sidharthv96
reviewed
Mar 1, 2023
| @@ -20,7 +20,7 @@ export function renderMermaidBlocksInElement(root: HTMLElement) { | |||
| renderMermaidElement(mermaidContainer); | |||
|
Closing in favour of #184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mermaid version 10.0.0 is the latest, but it has some breaking API changes.
I had to change the
mermaid.rendercall as it no longer accepts a callback.see https://github.com/mermaid-js/mermaid/blob/master/CHANGELOG.md#1000
N.B. I tested the rendering and it works for correct graph, but it does not render parsing errors.
I'm very new to node.js, so not sure if my changes are correct.
Any pointers on how to fix this would be appreciated.
Also:
css-loaderto resolve the major version conflict with webpack.npm-run-allas a dev dependency to makevscode:prepublishtask run on Windows correctly. (Powershell does not recognize;as a command delimiter )