Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer rely on joo_global_object #7

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

smorimoto
Copy link
Contributor

joo_global_object is deprecated and will result in a warning with the new release of jsoo.

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto force-pushed the get-rid-of-joo_global_object branch from 7c312e7 to a0c2f5c Compare December 26, 2024 10:26
Copy link
Owner

@mnxn mnxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mnxn mnxn merged commit 250987b into mnxn:trunk Jan 14, 2025
@smorimoto smorimoto deleted the get-rid-of-joo_global_object branch January 14, 2025 06:01
@smorimoto
Copy link
Contributor Author

Could you create a new release?

@mnxn
Copy link
Owner

mnxn commented Jan 15, 2025

smorimoto pushed a commit to ocaml/opam-repository that referenced this pull request Jan 15, 2025
CHANGES:

- No longer rely on `joo_global_object` (mnxn/promise_jsoo#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants