Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6518: fix interchange protocol for string columns #6523

Merged
merged 2 commits into from
Aug 31, 2023
Merged

FIX-#6518: fix interchange protocol for string columns #6523

merged 2 commits into from
Aug 31, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Aug 30, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: converting string columns to interchange protocol changes values to NaN #6518
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#6518: fix interchange protocol for string columns
7b6974a 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review August 30, 2023 22:42
@anmyachev anmyachev requested a review from a team as a code owner August 30, 2023 22:42
RehanSD
RehanSD previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vnlitvinov
vnlitvinov previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor performance suggestion

@anmyachev @vnlitvinov
Update modin/core/dataframe/pandas/interchange/dataframe_protocol/col…
e8367a1 
…umn.py

Co-authored-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
@anmyachev
Copy link
Collaborator Author

@RehanSD I think we can merge it

RehanSD
RehanSD approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RehanSD RehanSD merged commit 8e0e3cf into modin-project:master Aug 31, 2023
@anmyachev anmyachev deleted the issue6518 branch August 31, 2023 17:19
This was referenced Aug 31, 2023
Closed
Closed
This was referenced Aug 31, 2023
Closed
Closed
anmyachev added a commit to anmyachev/modin that referenced this pull request Oct 30, 2023
@anmyachev @vnlitvinov
FIX-modin-project#6518: fix interchange protocol for string columns (m…
afbf466 
…odin-project#6523)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Co-authored-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSD RehanSD RehanSD approved these changes

@vnlitvinov vnlitvinov vnlitvinov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: converting string columns to interchange protocol changes values to NaN
3 participants
@anmyachev @RehanSD @vnlitvinov