-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#7459: Add methods to get and set backend. #7460
Merged
sfc-gh-mvashishtha
merged 18 commits into
modin-project:main
from
sfc-gh-mvashishtha:7459/feat/add-get-and-set-backend-methods
Mar 13, 2025
Merged
FEAT-#7459: Add methods to get and set backend. #7460
sfc-gh-mvashishtha
merged 18 commits into
modin-project:main
from
sfc-gh-mvashishtha:7459/feat/add-get-and-set-backend-methods
Mar 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
…les. Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
…into 7459/feat/add-get-and-set-backend-methods
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
sfc-gh-jkew
approved these changes
Mar 12, 2025
|
||
@doc(SET_BACKEND_DOC, class_name=__qualname__) | ||
def set_backend(self, backend: str, inplace: bool = False) -> Optional[Self]: | ||
# TODO(https://github.com/modin-project/modin/issues/7467): refactor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm seeing the same issue
sfc-gh-joshi
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
get_backend()
to get the backend for a dataframe or series. Addset_backend()
, and its aliasmove_to()
, to set the backend of a dataframe or series.To implement
set_backend()
, extendFactoryDispatcher
so that it can dispatch I/O operations to the backend that the user chooses instead of always usingmodin.config.Backend
.set_backend()
can then useFactoryDispatcher.from_pandas(backend=new_backend)
to get a query compiler with the given backend.This commit also updates the documentation for "native" execution mode to reflect the updated guidance of using
Backend
to control execution. It also adds examples of usingget_backend()
andset_backend()
.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date