FEAT-#7448: Allow QueryCompilerCaster to apply cost-optimization on automatic casting #7464
+394
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from types import FunctionType, MethodType | ||
| from typing import Any, Dict, Tuple, TypeVar | ||
|
|
||
| from pandas.core.indexes.frozen import FrozenList | ||
|
|
||
| from modin.core.storage_formats.base.query_compiler import BaseQueryCompiler | ||
| from modin.core.storage_formats.base.query_compiler import ( | ||
| BaseQueryCompiler, |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
sfc-gh-jkew
changed the title
sfc-gh-jkew
changed the title
| from modin.core.storage_formats.base.query_compiler import BaseQueryCompiler | ||
| from modin.core.storage_formats.base.query_compiler import ( | ||
| BaseQueryCompiler, | ||
| QCCoercionCost, |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Currently a QueryCompiler derived from QueryCompilerCaster will cast all parameters, regardless of type to the query compiler we are calling an operation on. This CL introduces the ability to symmetrically cast to different query compilers based on a cost estimation.
Each query compiler implements a new function which can return a cost estimate of data migration from that specific compiler's perspective. On each operation involving mixed types we calculate the aggregate cost of migration across all query compilers and pick the query compiler class with the least cost.
The implementation of the cost-estimate, from each query compiler, can be anything, but it is constrained to a set of values between 0-1000.
Max Cost Not Implemented
This implementation still can face an issue where a workload is moved to the wrong engine, because there is no threshold on the cost of migration implemented. This can be implemented the future.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date