RUST-1314 Support on-demand AWS credentials for in-use encryption #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+352
to
+362
| pub(crate) fn access_key(&self) -> &str { | ||
| &self.access_key | ||
| } | ||
|
|
||
| pub(crate) fn secret_key(&self) -> &str { | ||
| &self.secret_key | ||
| } | ||
|
|
||
| pub(crate) fn session_token(&self) -> Option<&str> { | ||
| self.session_token.as_deref() | ||
| } |
There was a problem hiding this comment.
nit: could we just make the fields pub(crate) instead?
There was a problem hiding this comment.
I'd rather preserve the invariant that this struct can't be directly constructed or mutated.
src/test/csfle.rs
Outdated
| }) | ||
| .run() | ||
| .await; | ||
| assert!(result.is_err()); |
There was a problem hiding this comment.
is there a more specific error case/variant we can assert on here?
There was a problem hiding this comment.
Good call, updated this to check that it's an auth error.
isabelatkinson
approved these changes
Feb 28, 2023
abr-egn
added a commit
to abr-egn/mongo-rust-driver
that referenced
this pull request
Feb 28, 2023
abr-egn
added a commit
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1314
Happily, this turned out to be more straightforward than expected.