RUST-1411 Add create_encrypted_collection helper
#853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Apr 13, 2023
| @@ -259,7 +259,7 @@ impl Error { | |||
|
|
|||
| /// Gets the code from this error for performing SDAM updates, if applicable. | |||
| /// Any codes contained in WriteErrors are ignored. | |||
| pub(crate) fn code(&self) -> Option<i32> { | |||
| pub(crate) fn sdam_code(&self) -> Option<i32> { | |||
There was a problem hiding this comment.
Not for the first time, I got a bit confused when implementing the prose tests because this doesn't return a code for write errors, so I renamed this to be more clear it's got sdam-specific logic and added an unrestricted version.
abr-egn
force-pushed
the
RUST-1411/create-encrypted-collection
branch
from
89ee7e5 to
9ee3e7a
Compare
isabelatkinson
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.