Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUST-1421 Implement FromStr for Namespace #889

Merged
merged 4 commits into from
Jun 9, 2023
Merged

RUST-1421 Implement FromStr for Namespace #889

merged 4 commits into from
Jun 9, 2023

Conversation

drshika
Copy link
Contributor

@drshika drshika commented Jun 7, 2023

No description provided.

@drshika drshika marked this pull request as draft June 8, 2023 14:21
@drshika drshika marked this pull request as ready for review June 8, 2023 14:21
@abr-egn abr-egn self-requested a review June 8, 2023 14:24
abr-egn
abr-egn reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I think it'd be good to add a test to make sure multiple .s work (i.e. "foo.bar.baz" parses into "foo" and "bar.baz") and then it'll be good to go.

@drshika drshika requested a review from abr-egn June 8, 2023 18:12
abr-egn
abr-egn reviewed Jun 8, 2023
View reviewed changes
@drshika drshika requested a review from abr-egn June 8, 2023 18:26
abr-egn
abr-egn approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tagging in Isabel.

@abr-egn abr-egn requested a review from isabelatkinson June 8, 2023 18:29
isabelatkinson
isabelatkinson approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@drshika drshika merged commit 9ef3ada into mongodb:main Jun 9, 2023
@drshika drshika deleted the RUST-1421/from-str-for-namespace branch June 9, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abr-egn abr-egn abr-egn approved these changes

@isabelatkinson isabelatkinson isabelatkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drshika @abr-egn @isabelatkinson