RUST-1712 Provide a connection pool warmup method #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Aug 14, 2023
| /// | ||
| /// Note that topology changes require rebuilding the connection pool, so this method cannot | ||
| /// guarantee that the pool will always be filled for the lifetime of the `Client`. | ||
| pub async fn warm_connection_pool(&self) { |
There was a problem hiding this comment.
I'm open to naming suggestions here. "warm" seems a little vague but I couldn't think of a better one that wasn't super verbose.
There was a problem hiding this comment.
yeah this seems fine to me. can you note in the comment for this method that nothing will happen if min_pool_size is 0?
isabelatkinson
approved these changes
Aug 16, 2023
| /// | ||
| /// Note that topology changes require rebuilding the connection pool, so this method cannot | ||
| /// guarantee that the pool will always be filled for the lifetime of the `Client`. | ||
| pub async fn warm_connection_pool(&self) { |
There was a problem hiding this comment.
yeah this seems fine to me. can you note in the comment for this method that nothing will happen if min_pool_size is 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1712
This works by spawning a task that sends check out requests in a loop until the receiving worker reports that the pool has hit
min_pool_size. This is a little indirect but seems to have the fewest drawbacks compared to other methods I considered: