Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-1677, DRIVERS-1673: Add general logging specification and command logging #1303

Merged
merged 45 commits into from
Oct 14, 2022
Merged

DRIVERS-1677, DRIVERS-1673: Add general logging specification and command logging #1303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
195f581
DRIVERS-1204 add general spec, unified format changes, and command lo…
kmahar Sep 1, 2022
2359fbc
use $$matchAsDocument for matching empty documents
kmahar Sep 9, 2022
8bea9ab
fix link
kmahar Sep 9, 2022
5484c94
Apply suggestions from code review
kmahar Sep 14, 2022
998adcb
Apply suggestions from code review
kmahar Sep 14, 2022
2d406d7
make driverConnectionId optional and split out testing for it
kmahar Sep 13, 2022
3027e01
move tests up out of /unified subdirectories
kmahar Sep 13, 2022
4114394
clarify length in prose tests
kmahar Sep 13, 2022
6e0356a
add type assertions to tests
kmahar Sep 13, 2022
a628829
drivers must omit null values from messages
kmahar Sep 14, 2022
968d937
unstuctured -> unstructured
kmahar Sep 14, 2022
60ec05e
MUST -> SHOULD for unstructured message forms; pull out common values…
kmahar Sep 14, 2022
09e0316
address comments on unified test format
kmahar Sep 14, 2022
68f1dd0
address comments on general spec
kmahar Sep 15, 2022
b8d48eb
fix rst
kmahar Sep 15, 2022
be019e5
fix operationId test
kmahar Sep 15, 2022
001e6d2
fix object in operationId test
kmahar Sep 15, 2022
08275c7
add tests for no handshake and no heartbeat messages being emitted
kmahar Sep 16, 2022
cf77d2c
only run heartbeat test on non-LB topology; reorder ops
kmahar Sep 16, 2022
dc15477
update rationale for not requiring structured logging
kmahar Sep 16, 2022
e8b39be
update prose test to reflect it applies to any driver with a max leng…
kmahar Sep 16, 2022
b161034
fix emphasis
kmahar Sep 16, 2022
1afc10f
schema version should be 1.12
kmahar Sep 27, 2022
b441824
Merge branch 'master' into DRIVERS-1204/logging-spec
kmahar Sep 27, 2022
e998fed
bump test file schema versions
kmahar Sep 27, 2022
45b9d8b
add interruptInUseConnections to schema v1.12
kmahar Sep 27, 2022
8c01044
update command logging tests README
kmahar Oct 5, 2022
4a94ad0
reword
kmahar Oct 5, 2022
2f41ac7
make clear that drivers should do "naive" truncation of JSON, and add…
kmahar Oct 7, 2022
830c568
drivers must match exact names/casing for structured log messages
kmahar Oct 10, 2022
5bacb00
events -> messages, clarify that messages MUST be an exact match
kmahar Oct 11, 2022
3a22c27
bump schema versions in invalid tests
kmahar Oct 11, 2022
5b0224b
update redacton rules and unifited format support for testing for red…
kmahar Oct 11, 2022
e2c7209
update failureIsRedacted language slightly
kmahar Oct 11, 2022
0434dd8
Merge branch 'master' into DRIVERS-1204/logging-spec
kmahar Oct 11, 2022
2f5256e
back to a single boolean; fix typos
kmahar Oct 12, 2022
73a0b3c
Merge remote-tracking branch 'origin' into DRIVERS-1204/logging-spec
kmahar Oct 12, 2022
7174ad7
address jmikola comments
kmahar Oct 13, 2022
bc6cdf6
schema version 1.12 -> 1.13
kmahar Oct 14, 2022
13e9593
Merge remote-tracking branch 'origin' into DRIVERS-1204/logging-spec
kmahar Oct 14, 2022
cfd852a
fix changelog date
kmahar Oct 14, 2022
042f20c
bump schema version in unified tests makefile
kmahar Oct 14, 2022
7a63673
update CLAM spec name in makefile
kmahar Oct 14, 2022
9358d08
consistent driver connection ID type in events
kmahar Oct 14, 2022
91464fa
address @BorisDog comments
kmahar Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 68 additions & 34 deletions source/command-logging-and-monitoring/tests/logging/redacted-commands.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": true,
"data": {
"message": "Command failed",
"commandName": "authenticate"
"commandName": "authenticate",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -139,11 +141,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "authenticate"
"commandName": "authenticate",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -188,11 +192,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": true,
"data": {
"message": "Command failed",
"commandName": "saslStart"
"commandName": "saslStart",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -256,11 +262,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "saslStart"
"commandName": "saslStart",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -305,11 +313,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": true,
"data": {
"message": "Command failed",
"commandName": "saslContinue"
"commandName": "saslContinue",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -373,11 +383,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "saslContinue"
"commandName": "saslContinue",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -484,11 +496,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "getnonce"
"commandName": "getnonce",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -533,11 +547,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": true,
"data": {
"message": "Command failed",
"commandName": "createUser"
"commandName": "createUser",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -601,11 +617,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "createUser"
"commandName": "createUser",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -650,11 +668,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": true,
"data": {
"message": "Command failed",
"commandName": "updateUser"
"commandName": "updateUser",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -718,11 +738,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "updateUser"
"commandName": "updateUser",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -765,11 +787,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": true,
"data": {
"message": "Command failed",
"commandName": "copydbgetnonce"
"commandName": "copydbgetnonce",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -836,11 +860,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "copydbgetnonce"
"commandName": "copydbgetnonce",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -883,11 +909,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": true,
"data": {
"message": "Command failed",
"commandName": "copydbsaslstart"
"commandName": "copydbsaslstart",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -954,11 +982,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "copydbgetnonce"
"commandName": "copydbgetnonce",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -1001,11 +1031,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": true,
"data": {
"message": "Command failed",
"commandName": "copydb"
"commandName": "copydb",
"failure": {
"$$exists": true
}
}
}
]
Expand Down Expand Up @@ -1072,11 +1104,13 @@
{
"level": "debug",
"component": "command",
"hasFailure": true,
"failureIsRedacted": false,
"data": {
"message": "Command failed",
"commandName": "copydb"
"commandName": "copydb",
"failure": {
"$$exists": true
}
}
}
]
Expand Down
Loading