minor: regenerate JSON files #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
requested review from
nbbeeken and
BorisDog
and removed request for
a team
nbbeeken
approved these changes
Nov 1, 2022
|
Looks like this is related to DRIVERS-1707 cc @Neilshweky @DmitryLukyanov |
| @@ -54,7 +47,14 @@ | |||
| "commandFailedEvent", | |||
| "connectionCheckedOutEvent", | |||
| "connectionCheckedInEvent" | |||
| ] | |||
| ], | |||
There was a problem hiding this comment.
some minor formatting fix was applied yesterday, but I would not expect such change in order..
| "name": "find", | ||
| "object": "collection", | ||
| "arguments": { | ||
| "filter": { |
There was a problem hiding this comment.
I don't understand why this change was applied, but probably it's not a big deal
There was a problem hiding this comment.
js-yaml does not inline non-empty objects. By default, keys within an object appear indented on their own line between the opening and closing braces. Likewise for array elements.
DmitryLukyanov
approved these changes
Nov 1, 2022
Neilshweky
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why, but when I regenerated files after making some changes in #1324 these ones changed. Seems like they had not been properly regenerated for whatever reason and the GitHub Action checking the files did not pick it up.