feat: use lucide icon instead of svg #7553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm quite reluctant to use dependencies in the project, I believe that using inline SVGs is not ideal for the codebase because it can be messy. Additionally, using custom icons creates inconsistency.
I've been using on other projects https://lucide.dev icons and they are just great.
So we are moving from custom SVG icons to a library of icons.
In terms of performance there are no impact since they are using tree-shaking to make sure we only load what we need.
I haven't replaced the icons everywhere, I need further testing for some pages, but the most has been done here.