This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Keep a local ref of the NSImage so it doesn't try to get reconstructed #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSMac is getting some exceptions that we are trying to resurrect the image in this code, so keep a local copy of the NSImage... Here is the part of the exception callstack: "ObjCRuntime.Runtime.MissingCtor(IntPtr,IntPtr,Type,MissingCtorResolution)", "ObjCRuntime.Runtime.ConstructNSObject[T](IntPtr,Type,MissingCtorResolution)", "ObjCRuntime.Runtime.GetNSObject[T](IntPtr)", "AppKit.NSImageView.get_Image()", "Xwt.Mac.ImageViewBackend.SetImage(ImageDescription)", "Xwt.ImageView.set_Image(Image)",
mrward
approved these changes
Mar 13, 2023
| @@ -53,16 +53,20 @@ protected override Size GetNaturalSize () | |||
| NSImage img = Widget.Image; | |||
| return img == null ? Size.Zero : img.Size.ToXwtSize (); | |||
| } | |||
|
|
|||
| NSImage nsImage; // Needed to keep a ref, otherwise Xam.Mac might GC it and try to resurrect it | |||
There was a problem hiding this comment.
Should this ViewBackend override Dispose(bool) and dispose the nsImage? I don't really know when IWidgetBackend.Dispose is called, maybe we don't need to care about this? Just a thought.
There was a problem hiding this comment.
Good catch! If Widget still holds a reference to the native part of NSImage, and ViewBackend doesn't dispose of Widget when it gets disposed, would disposing of the nsImage put it into a weird state? What if we just nulled out the nsImage?
There was a problem hiding this comment.
Hmm, not sure. Nulling it out is probably better than nothing in terms of spreading out GC pressure.
BTW, you can now rewrite GetNaturalSize to use nsImage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSMac is getting some exceptions that we are trying to resurrect the image in this code, so keep a local copy of the NSImage...
Here is the part of the exception callstack:
"ObjCRuntime.Runtime.MissingCtor(IntPtr,IntPtr,Type,MissingCtorResolution)", "ObjCRuntime.Runtime.ConstructNSObject[T](IntPtr,Type,MissingCtorResolution)",
"ObjCRuntime.Runtime.GetNSObject[T](IntPtr)",
"AppKit.NSImageView.get_Image()",
"Xwt.Mac.ImageViewBackend.SetImage(ImageDescription)", "Xwt.ImageView.set_Image(Image)",