Improve performance for TreeSearch #1
Merged
+95
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental, hence this is on a different branch. This commit vastly improves performance by not updating the tree for search mask changes. Relates to: limbonaut#229
- Carefully manage callable_cache - Only clear filter when previously filtered - Reintroduce sorting for ordered_tree_items This commit addresses performance issues in TreeSearch and fixes a critical bug where ordered_tree_items was not being sorted. The bug was introduced during a merge with the main feature branch.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses limbonaut#229 -> Searches do a whole tree reconstruction for now: Noticeable lag.
Makesearch_maskupdates not reconstruct the Tree viaTaskTreeOptimize callable_cache managementSelectively clear filter only when previously appliedUseTree::queue_redrawwhen possible instead of reassigning the draw callback.