Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve @hashmap.to_array performance #1723

Merged
merged 1 commit into from
Mar 6, 2025
Merged

improve @hashmap.to_array performance #1723

merged 1 commit into from
Mar 6, 2025

Conversation

illusory0x0
Copy link
Contributor

avoid use Array::push

@coveralls
Copy link
Collaborator

coveralls commented Mar 1, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 5565

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 92.547%
Changes Missing Coverage Covered Lines Changed/Added Lines %
hashmap/utils.mbt 9 10 90.0%
Totals Coverage Status
Change from base Build 5564: -0.008%
Covered Lines: 6010
Relevant Lines: 6494
💛 - Coveralls

@bobzhang bobzhang force-pushed the improve-hashmap.to_array branch from d50cad6 to 66ca3a9 Compare March 6, 2025 07:54
@bobzhang bobzhang enabled auto-merge (rebase) March 6, 2025 08:11
@bobzhang bobzhang disabled auto-merge March 6, 2025 08:11
@bobzhang bobzhang merged commit fc244ea into moonbitlang:main Mar 6, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illusory0x0 @coveralls @bobzhang