adds copy for the name of a shortcut to reopen current tab in a specific container #31
Conversation
| @@ -419,6 +419,15 @@ | |||
| } | |||
| } | |||
| }, | |||
| "reopenInContainerShortcut": { | |||
| "message": "Reopen in Container $keyId$", | |||
There was a problem hiding this comment.
Why "Container" uppercase?
There was a problem hiding this comment.
Thanks for the fast feedback @flodolo
"Container" is capitalized to indicate that it is a significant term within the application.
Also it is capitalized in most of the cases across the file.
There was a problem hiding this comment.
You're right 🤔 (there are 5 of them with lowercase container though).
Keeping this one open until there is agreement in the main code repository.
There was a problem hiding this comment.
I don't see any activity in the PR you linked to.
I've also raised that this workflow doesn't really work if there is no UX/content driving decisions, so we might need to change it.
There was a problem hiding this comment.
Sorry I didn't get what you mean. What should I do?
There was a problem hiding this comment.
Wait for a developer to comment in mozilla/multi-account-containers#2721
There was a problem hiding this comment.
thanks. I'm waiting. So want start using this feature
| @@ -419,6 +419,15 @@ | |||
| } | |||
| } | |||
| }, | |||
| "reopenInContainerShortcut": { | |||
| "message": "Reopen in Container $keyId$", | |||
There was a problem hiding this comment.
You're right 🤔 (there are 5 of them with lowercase container though).
Keeping this one open until there is agreement in the main code repository.
needed for this mozilla/multi-account-containers#2721
reopen.in.container.with.shortcut.mov