Rework LoggingBackend and timestamps (#11) #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
force-pushed
the
11-logging-timestamp
branch
2 times, most recently
from
3938db9 to
85a4ddb
Compare
This adds a new "timestamp_mode" which changes the behavior of the timestamp in the logged output. * "utc": inserts a UTC timestamp * "local": inserts a local timezone timestamp * anything: doesn't insert a timestamp at all In the cases where I'm using Markus in a local dev environment for service development, the logging framework is already configured with a timestamp, so having Markus' LoggingBackend also include a timestamp is redundant and not wildly helpful. Thus I wanted to include a "no timestamp" option. For when the user wants a timestamp, it seemed prudent to support both UTC and local timezone timestamps. Also, timestamps are now emitted in isoformat.
willkg
force-pushed
the
11-logging-timestamp
branch
from
85a4ddb to
f015254
Compare
robhudson
reviewed
Oct 30, 2024
HISTORY.rst
Outdated
|
|
||
| No timestamp example:: | ||
|
|
||
| LoggingBackend() |
There was a problem hiding this comment.
Should this be LoggingMetrics?
There was a problem hiding this comment.
Whoops! Thank you for catching this!
|
I like the changes here...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new "timestamp_mode" which changes the behavior of the timestamp in the logged output.
In the cases where I'm using Markus in a local dev environment for service development, the logging framework is already configured with a timestamp, so having Markus' LoggingBackend also include a timestamp is redundant and not wildly helpful. Thus I wanted to include a "no timestamp" option.
For when the user wants a timestamp, it seemed prudent to support both UTC and local timezone timestamps.
Also, timestamps are now emitted in isoformat.
Fixes #11.