Implements vanilla StatsD backend #20
Conversation
|
|
||
| .. seealso:: | ||
|
|
||
| http://docs.datadoghq.com/guides/metrics/ |
There was a problem hiding this comment.
This seealso should probably be a different url so people who follow it don't get confused by Datadog statsd enhancements.
Maybe this url?: http://statsd.readthedocs.io/en/v3.2.1/configure.html
| self.client.timing(stat=stat, delta=value) | ||
|
|
||
| def histogram(self, stat, value, tags=None): | ||
| """Measure a value for statistical distribution""" |
There was a problem hiding this comment.
This should mention that it's turning around and using the timing, too. Kind of like how I did this:
| @@ -54,7 +54,8 @@ def get_file(fn): | |||
| 'six', | |||
| ], | |||
| extra_requires={ | |||
| 'datadog': ['datadog'] | |||
| 'datadog': ['datadog'], | |||
| 'statsd': ['statd'], | |||
There was a problem hiding this comment.
I think this should be;
'statsd': ['statsd'],
| assert ( | ||
| ddm.client.calls == | ||
| [('timing', (), {'stat': 'foo', 'delta': 4321})] | ||
| ) |
There was a problem hiding this comment.
These tests are great!
Having said that, if you have better ideas for how to test backends in Markus, I'm all ears.
|
I had a couple of minor issues, but otherwise this is great! If you could fix those, I'd love to merge this. Thank you! |
|
@jruere How's this coming along? Is there anything I can do to help you land it? |
|
Sorry, I'm quite busy ATM and I could not use the project internally in the end. I'm not sure when I'll resume this work. |
|
That's totally fine! I can take this and finish it up. Thank you for working on it! |
|
I took what you did and then finished it up. That's in pull request #22. Thank you for working on this! |
Implemented as discussed in #3.