Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert unsupported config change #485

Merged
merged 1 commit into from
Mar 12, 2020
Merged

fix: revert unsupported config change #485

merged 1 commit into from
Mar 12, 2020

Conversation

tublitzed
Copy link
Contributor

Description

This reverts a PR that added a config change that it looks like was never actually implemented in Rust.

Looks like I was so excited to find the config value I was hoping for, I missed the fact that what was merged was an rfc not actual support for it.

Testing

  1. make run against master. See this warning warning: unused manifest key: package.rust
  2. make run in this branch. Verify no more warning.

Issue(s)

References #424

@tublitzed tublitzed requested a review from a team March 12, 2020 13:11
@fzzzy fzzzy merged commit c137b89 into master Mar 12, 2020
@fzzzy fzzzy deleted the chore/revert-msrv branch March 12, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants