Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error of generating structures with arrays inside and keyword as #1055

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

PuffyWithEyes
Copy link

Created a correction associated with this issue

@PuffyWithEyes
Copy link
Author

Perhaps you should add converting to one or another type (C-style)

@PuffyWithEyes PuffyWithEyes requested a review from emilio February 20, 2025 11:13
@PuffyWithEyes
Copy link
Author

@emilio thank you for the remark!

@@ -270,6 +270,7 @@ impl ConstExpr {
let generic_path = GenericPath::load(&path.path)?;
Ok(ConstExpr::Name(generic_path.export_name().to_owned()))
}
syn::Expr::Cast(ref cast) => Ok(ConstExpr::load(&cast.expr)?),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be simpler by just using => Self::load(&cast.expr) rather than that. But no big deal.

@emilio emilio added this pull request to the merge queue Feb 21, 2025
Merged via the queue into mozilla:master with commit b105f55 Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants