Set returnValues.suggestedLength to Content-Length if integer

[kevinleedrum]

Fixes #9103 by setting returnValues.suggestedLength to the value of Content-Length (provided it is an integer) even if returning early.

[timvandermeij]

Looks good. Could you squash the commits into one for review? Refer to https://github.com/mozilla/pdf.js/wiki/Squashing-Commits for how to do that easily if you're not familiar with the process.

[Snuffleupagus]

What about the final point from #9103 (comment), is that not necessary after all?

[...] so perhaps it makes sense to unconditionally use the value of the Content-Length header (unless Transfer-Encoding is specified but not starting with identity).

[kevinleedrum]

What about the final point from #9103 (comment), is that not necessary after all?

[...] so perhaps it makes sense to unconditionally use the value of the Content-Length header (unless Transfer-Encoding is specified but not starting with identity).

I believe the Content-Length should not be present anyway if Transfer-Encoding is specified. https://tools.ietf.org/html/rfc7230#section-3.3.2

[timvandermeij]

@Rob--W Time permitting, would you be willing to review this?

[Rob--W]

Looks good in general. The defaultValues variable in the test is now used only once, and it would make more sense to replace that only use with the value itself.

[kevinleedrum]

The defaultValues variable in the test is now used only once, and it would make more sense to replace that only use with the value itself.

Done. 👍

[Rob--W]

Thanks for the change. This is good to merge if the tests pass.

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e1a315c8925abcf/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/4389d3f37ae906b/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/e1a315c8925abcf/output.txt

Total script time: 19.58 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.215.176.217:8877/4389d3f37ae906b/output.txt

Total script time: 23.97 mins

• Font tests: FAILED
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/4389d3f37ae906b/reftest-analyzer.html#web=eq.log

[timvandermeij]

/botio-windows fonttest

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_fonttest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/1145fa4cfe6ddd7/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.215.176.217:8877/1145fa4cfe6ddd7/output.txt

Total script time: 2.82 mins

• Font Tests: Passed

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2ebf18b0b05d201/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/2ebf18b0b05d201/output.txt

Total script time: 2.86 mins

Published

• Viewer: http://54.67.70.0:8877/2ebf18b0b05d201/web/viewer.html

[timvandermeij]

Thank you!