Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore referrer preserving functionality in Chrome 72+ #10869

Merged
merged 1 commit into from
May 29, 2019
Merged

Restore referrer preserving functionality in Chrome 72+ #10869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions extensions/chromium/preserve-referer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,26 @@ var g_requestHeaders = {};
// g_referrers[tabId][frameId] = referrer of PDF frame.
var g_referrers = {};

var extraInfoSpecWithHeaders; // = ['requestHeaders', 'extraHeaders']

(function() {
var requestFilter = {
urls: ['*://*/*'],
types: ['main_frame', 'sub_frame'],
};
chrome.webRequest.onSendHeaders.addListener(function(details) {
g_requestHeaders[details.requestId] = details.requestHeaders;
}, requestFilter, ['requestHeaders']);
function registerListener(extraInfoSpec) {
extraInfoSpecWithHeaders = extraInfoSpec;
// May throw if the given extraInfoSpec is unsupported.
chrome.webRequest.onSendHeaders.addListener(function(details) {
g_requestHeaders[details.requestId] = details.requestHeaders;
}, requestFilter, extraInfoSpec);
}
try {
registerListener(['requestHeaders', 'extraHeaders']);
} catch (e) {
// "extraHeaders" is not supported in Chrome 71 and earlier.
registerListener(['requestHeaders']);
}
chrome.webRequest.onBeforeRedirect.addListener(forgetHeaders, requestFilter);
chrome.webRequest.onCompleted.addListener(forgetHeaders, requestFilter);
chrome.webRequest.onErrorOccurred.addListener(forgetHeaders, requestFilter);
Expand Down Expand Up @@ -105,7 +117,7 @@ chrome.runtime.onConnect.addListener(function onReceivePort(port) {
urls: [data.requestUrl],
types: ['xmlhttprequest'],
tabId: tabId,
}, ['blocking', 'requestHeaders']);
}, ['blocking', ...extraInfoSpecWithHeaders]);
}
// Acknowledge the message, and include the latest referer for this frame.
port.postMessage(referer);
Expand Down