upgrade ar crate so we can do less copying when trimming rlibs #790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current trimming of rlibs in the dist-sccache case looks like:
rust.metadata.bin
file in the rlib (archive).We can do better than this, by doing the following:
rust.metadata.bin
file in the rlib (archive).We thus save a copy.
All that being said, it looks like recent versions of Rust don't
actually output
rust.metadata.bin
files into rlibs...unless we oughtto be only taking the
lib.rmeta
file that lives inside the archive.But that would be a separate fix. (It's also great that we're seemingly
copying the rmeta file twice, once because it lives in the rlib and once
because it lives on disk as a separate file...)