Password string #625
Password string #625
Conversation
public/locales/en-US/send.ftl
Outdated
| @@ -87,3 +87,4 @@ footerLinkCookies = Cookies | |||
| requirePasswordCheckbox = Require a password to download this file | |||
| addPasswordButton = Add password | |||
| passwordTryAgain = Incorrect password. Try again. | |||
| passwordResult = Password: | |||
There was a problem hiding this comment.
Can you add a short localization note? e.g.
// This label is followed by the password set to download a file
Is it just me or #622 shows a completely different string?
There was a problem hiding this comment.
It does, though I believe the consensus was to change it to just be "password", though it's possible that's just what it became in the last iteration....
There was a problem hiding this comment.
#381 (comment) has the mockups (last image in "sender" shows the string "Password required to download this file:")
There was a problem hiding this comment.
I double-checked with some folks, and the long one is preferred. Changing it, thanks!
ericawright
force-pushed
the
password-string
branch
from
ef290be to
4bd3df7
Compare
ericawright
force-pushed
the
password-string
branch
from
4bd3df7 to
b4997a8
Compare
|
This looks good, but I made some other changes in another PR, so I'm closing this... To maybe make RTL better, in #632, I made the password an ftl variable, and also some inside baseball changes to make other weird passwords (besides multiple spaces) work better. |
Fixes: #621.
Fixes: #622.