don't show the download button until the filename is loaded #736
Conversation
| @@ -38,6 +38,10 @@ module.exports = function(state, emit) { | |||
| </button> | |||
| </div> | |||
| </div>`; | |||
| if (!state.transfer) { | |||
| const ele = action.querySelector('#download-btn'); | |||
There was a problem hiding this comment.
This breaks on the server side. The server also runs this code from here, but there action is not a DOMElement it's just a string. So we end up in the catch case which falls through to the notfound code.
A good way to make it work on both the server and browser is to conditionally add the button in the action template string instead of removing it after.
There was a problem hiding this comment.
Sure I will look into this in a while
|
Thanks @himanish-star, I got a chance to fix this myself yesterday. I've integrated a fix for this in #737 |
|
😞, sorry for the delay.Fine I'll fix another issue |
|
@dannycoates, could you assign me some other issue which you think I can solve? In the meanwhile even I am looking out for some issues which I can solve. |
fixes: #733
@dannycoates, I have implemented the part you have requested for. Please review 😃