Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added direct support for Shelly Gen2+ devices #43

Closed
wants to merge 4 commits into from

Conversation

jjdejong
Copy link

It was somewhat awkward to have to use something like Node-RED to map the Shelly MQTT data to the format required by the original driver. So I coded a direct support for my Shelly devices.

@mr-manuel
Copy link
Owner

Why are you not using https://github.com/victronenergy/dbus-shelly/?

@jjdejong
Copy link
Author

Why are you not using https://github.com/victronenergy/dbus-shelly/?

Only supports the very specific Shelly Pro EM devices that use a totally different JSON payload. I tried to adapt that, but didn't succeed.

@jjdejong
Copy link
Author

jjdejong commented Dec 10, 2024

By the way, this code also merges some reformatting from a 0.18 fork that wasn't in the main branch. In fact a lot of the changes are just reformatting, so it may be confusing as to what effectively changes... I can remove the reformatting if you prefer.

@jjdejong
Copy link
Author

OK, removed all the code reformatting. Only the essential changes are visible.

@mr-manuel
Copy link
Owner

Thank you for your contribution. I simplified the integration a bit, so no extra config is needed.

mr-manuel added a commit that referenced this pull request Dec 20, 2024
@jjdejong
Copy link
Author

Thank you for your contribution. I simplified the integration a bit, so no extra config is needed.

Cool, by detecting "apower" in the JSON payload ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants