Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve ES6 template literals #7

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Preserve ES6 template literals #7

merged 1 commit into from
Dec 6, 2018

Conversation

mrclay
Copy link
Owner

@mrclay mrclay commented Jul 19, 2016

@futtta
Copy link

futtta commented Nov 6, 2018

This is not merged into JSmin master or into Minify yet @mrclay ? Any specific reason why you've held back on this?

I have some Autoptimize users who are getting those nasty

PHP Fatal error: Uncaught JSMin_UnterminatedStringException: JSMin: Unterminated String

errors due to this, so I will patch this in AO, but ideally this goes in JSMin (& Minify) as well to avoid me having to maintain a separate version?

zytzagoo added a commit to zytzagoo/autoptimize that referenced this pull request Nov 7, 2018
futtta pushed a commit to futtta/autoptimize that referenced this pull request Nov 7, 2018
@mrclay
Copy link
Owner Author

mrclay commented Nov 12, 2018

@futtta Are you confident this patch doesn’t introduce other bugs?

@futtta
Copy link

futtta commented Nov 12, 2018

pretty much, yes mrclay ; we actually had this in AO 2.3.4 already, running on over half a million wordpress sites without known issues,

when working on the big 2.4 rewrite-fest for which we re-downloaded the original minifiers I forgot to re-apply this to jsmin, which I how I found out about this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants