Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logs from GCodeLoader #16056

Closed
wants to merge 1 commit into from
Closed

Remove logs from GCodeLoader #16056

wants to merge 1 commit into from

Conversation

tentone
Copy link
Contributor

@tentone tentone commented Mar 25, 2019

Hi

  • Removed logs from gcodeloader.
  • Kept the arc command check with comment in case somebody wants to implement it later.

Cheers

@WestLangley
Copy link
Collaborator

Thanks for this.

Maybe just comment the logs out, and they can be un-commented for debugging. What do you think?

@mrdoob
Copy link
Owner

mrdoob commented Mar 25, 2019

Maybe just comment the logs out, and they can be un-commented for debugging. What do you think?

That sounds better to me yeah.

@mrdoob mrdoob added this to the r103 milestone Mar 25, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 27, 2019

615c99f

@mrdoob mrdoob closed this Mar 27, 2019
@WestLangley
Copy link
Collaborator

Thanks!

@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r103
Development

Successfully merging this pull request may close these issues.
3 participants
@tentone @WestLangley @mrdoob