Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WebGLRenderLists.d.ts #16083

Merged
merged 7 commits into from
Mar 29, 2019
Merged

Improve WebGLRenderLists.d.ts #16083

merged 7 commits into from
Mar 29, 2019

Conversation

0b5vr
Copy link
Collaborator

@0b5vr 0b5vr commented Mar 28, 2019 •
edited
Loading

related to #16062

  • Add definition of groupOrder parameter of WebGLRenderLists.push
  • Fix type definition of WebGLRenderLists.transparent
  • Add definition of WebGLRenderLists.unshift
  • geometry now only accepts BufferGeometry
  • Mark geometry and group as nullable

@0b5vr 0b5vr changed the title WebGLRenderLists.d.ts: WebGLRenderLists.push forgot groupOrder Improve WebGLRenderLists.d.ts Mar 28, 2019
Mugen87
Mugen87 reviewed Mar 28, 2019
View reviewed changes
src/renderers/webgl/WebGLRenderLists.d.ts Outdated
): void;
unshift(
object: Object3D,
geometry: Geometry | BufferGeometry,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of the geometry is always BufferGeometry. This is ensures by WebGLObjects.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also whoa

three.js/src/renderers/WebGLRenderer.js

Line 1294 in 0d18a75

currentRenderList.push( object, null, object.material, groupOrder, _vector3.z, null );

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I addressed both, thank you to point out this 🙏

@mrdoob mrdoob added this to the r104 milestone Mar 29, 2019
@mrdoob mrdoob merged commit 072cf7b into mrdoob:dev Mar 29, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 29, 2019

Thanks!

@0b5vr 0b5vr deleted the webglrenderlists-d-ts branch April 1, 2019 05:20
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r104
Development

Successfully merging this pull request may close these issues.
3 participants
@0b5vr @mrdoob @Mugen87