forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64: dts: qcom: msm8916-longcheer-l8910: add rear camera support #366
Open
a-andre
wants to merge
6
commits into
msm8916-mainline:wip/msm8916/6.14-rc2
Choose a base branch
from
a-andre:bqx5_cam_rear
base: wip/msm8916/6.14-rc2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
arm64: dts: qcom: msm8916-longcheer-l8910: add rear camera support #366
a-andre
wants to merge
6
commits into
msm8916-mainline:wip/msm8916/6.14-rc2
from
a-andre:bqx5_cam_rear
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
389c263
to
d897b4c
Compare
TravMurav
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Are you planning to send these changes upstream?
6d1daff
to
5a1a87c
Compare
5a1a87c
to
f48a84e
Compare
f48a84e
to
6a23680
Compare
6a23680
to
a1af28a
Compare
1711412
to
96e2b64
Compare
96e2b64
to
7eb9ee7
Compare
02a4f0d
to
29994a7
Compare
Replace the magic link bit rate number (4800) by its calculation based on the used parameters and the provided external clock frequency. The link bit rate is output bitrate multiplied by the number lanes. The output bitrate is the OPPXCK clock frequency multiplied by the number of bits per pixel. The OPPXCK clock frequency is OPCK multiplied by the OPPXCK clock division ratio. And OPCK is the external clock frequency multiplied by the PreDivider setting and the PLL multiple setting. Signed-off-by: André Apitzsch <git@apitzsch.eu>
Move clock frequency related parameters out of the constant register sequences, such that the hard coded external clock frequency can be replaced by a variable in the next commit. Signed-off-by: André Apitzsch <git@apitzsch.eu>
Replace the hard coded external clock frequency by the one read from device tree. Signed-off-by: André Apitzsch <git@apitzsch.eu>
Qualcomm MSM8916 devices only provide an external clock of 23.88MHz. Make the sensor usable by those devices by adding support for this frequency. Signed-off-by: André Apitzsch <git@apitzsch.eu>
Add rear camera support, using imx214 sensor. Signed-off-by: André Apitzsch <git@apitzsch.eu>
CONFIG_VIDEO_IMX214=m Signed-off-by: André Apitzsch <git@apitzsch.eu>
29994a7
to
dc90267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera should work out of the box with snapshot. (It might be necessary to install
gst-plugins-good
andlibcamera-*
manually.)For megapixels the config file
~/.config/megapixels/config/longcheer,l8910.ini
needs to be created:1920
and1080
can also be replaced4096
and2304
, respectively.