Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: qcom: msm8916-longcheer-l8910: add rear camera support #366

Open
wants to merge 6 commits into
base: wip/msm8916/6.14-rc2
Choose a base branch
from

Conversation

a-andre
Copy link

@a-andre a-andre commented Aug 26, 2024

The camera should work out of the box with snapshot. (It might be necessary to install gst-plugins-good and libcamera-* manually.)

For megapixels the config file ~/.config/megapixels/config/longcheer,l8910.ini needs to be created:

[device]
make=BQ
model=X5

[rear]
driver=imx214
media-driver=qcom-camss
capture-width=1920
capture-height=1080
capture-rate=30
capture-fmt=RGGB10P
preview-width=1920
preview-height=1080
preview-rate=30
preview-fmt=RGGB10P
rotate=0
media-links=imx214:0->msm_csiphy0:0,msm_csiphy0:1->msm_csid0:0,msm_csid0:1->msm_ispif0:0,msm_ispif0:1->msm_vfe0_rdi0:0
mirrored=false

1920 and 1080 can also be replaced 4096 and 2304, respectively.

@a-andre a-andre force-pushed the bqx5_cam_rear branch 5 times, most recently from 389c263 to d897b4c Compare August 28, 2024 20:52
@a-andre a-andre changed the base branch from wip/msm8916/6.11-rc3 to wip/msm8916/6.11-rc5 August 28, 2024 20:53
@a-andre a-andre marked this pull request as ready for review August 28, 2024 20:53
Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Are you planning to send these changes upstream?

@a-andre a-andre changed the base branch from wip/msm8916/6.11-rc5 to wip/msm8916/6.12-rc3 October 20, 2024 22:23
@a-andre a-andre changed the base branch from wip/msm8916/6.12-rc3 to wip/msm8916/6.13-rc2 December 16, 2024 21:34
@a-andre a-andre changed the base branch from wip/msm8916/6.13-rc2 to wip/msm8916/6.13-rc7 January 26, 2025 21:46
@a-andre a-andre force-pushed the bqx5_cam_rear branch 2 times, most recently from 1711412 to 96e2b64 Compare February 5, 2025 22:08
@a-andre a-andre changed the base branch from wip/msm8916/6.13-rc7 to wip/msm8916/6.14-rc2 February 15, 2025 15:18
@a-andre a-andre force-pushed the bqx5_cam_rear branch 2 times, most recently from 02a4f0d to 29994a7 Compare February 16, 2025 15:27
André Apitzsch added 6 commits February 16, 2025 18:55
Replace the magic link bit rate number (4800) by its calculation based
on the used parameters and the provided external clock frequency.

The link bit rate is output bitrate multiplied by the number lanes. The
output bitrate is the OPPXCK clock frequency multiplied by the number of
bits per pixel. The OPPXCK clock frequency is OPCK multiplied by the
OPPXCK clock division ratio. And OPCK is the external clock frequency
multiplied by the PreDivider setting and the PLL multiple setting.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
Move clock frequency related parameters out of the constant register
sequences, such that the hard coded external clock frequency can be
replaced by a variable in the next commit.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
Replace the hard coded external clock frequency by the one read from
device tree.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
Qualcomm MSM8916 devices only provide an external clock of 23.88MHz.
Make the sensor usable by those devices by adding support for this
frequency.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
Add rear camera support, using imx214 sensor.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
CONFIG_VIDEO_IMX214=m

Signed-off-by: André Apitzsch <git@apitzsch.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants